Skip to content

TST: make flaky zip check less strict #40837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2021
Merged

TST: make flaky zip check less strict #40837

merged 3 commits into from
Apr 13, 2021

Conversation

mzeitlin11
Copy link
Member

Saw this failure the other day:

pandas/tests/io/test_gcs.py:137: 
71
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
72

73
result = b'PK\x03\x04\x14\x00\x00\x00\x08\x00\xe0\xa1\x87R3ET~\x18\x06\x00\x00\x8c\n\x00\x00\x03\x00\x00\x00zip-\x96]WT;\x0c\x8...x00\x00\x00\x00\x80\x01\x00\x00\x00\x00zipPK\x05\x06\x00\x00\x00\x00\x01\x00\x01\x001\x00\x00\x009\x06\x00\x00\x00\x00'
74
expected = b'PK\x03\x04\x14\x00\x00\x00\x08\x00\xdd\xa1\x87R3ET~\x18\x06\x00\x00\x8c\n\x00\x00\x03\x00\x00\x00zip-\x96]WT;\x0c\x8...x00\x00\x00\x00\x80\x01\x00\x00\x00\x00zipPK\x05\x06\x00\x00\x00\x00\x01\x00\x01\x001\x00\x00\x009\x06\x00\x00\x00\x00'

The failing byte was the 10th, based on the linked wikipedia page in assert_equal_zip_safe, looks like 10th and 11th are last modified timestamp related, so may as well not check the 10th byte as well.

@mzeitlin11 mzeitlin11 added Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail labels Apr 8, 2021
@mroeschke mroeschke added this to the 1.3 milestone Apr 11, 2021
@jreback jreback merged commit 33b11d5 into pandas-dev:master Apr 13, 2021
@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the flaky_zip branch April 13, 2021 16:53
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@mzeitlin11 @JulianWgs
TST: make flaky zip check less strict (pandas-dev#40837)
f4b8661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mzeitlin11 @jreback @mroeschke